Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: enable pushdown substring/char_length to tikv #30193

Merged
merged 5 commits into from
Nov 28, 2021
Merged

expression: enable pushdown substring/char_length to tikv #30193

merged 5 commits into from
Nov 28, 2021

Conversation

guo-shaoge
Copy link
Collaborator

@guo-shaoge guo-shaoge commented Nov 27, 2021 •
edited
Loading

Signed-off-by: guo-shaoge shaoge1994@163.com

What problem does this PR solve?

Issue Number: close #30200

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@guo-shaoge
expression: enable pushdown substring to tikv
7f633e4 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 27, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • bb7133

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels Nov 27, 2021
@ti-chi-bot
Copy link
Member

@guo-shaoge: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 27, 2021
@guo-shaoge
Copy link
Collaborator Author

/run-check_dev_2

@bb7133
Copy link
Member

bb7133 commented Nov 27, 2021

LGTM

bb7133
bb7133 previously approved these changes Nov 27, 2021
View reviewed changes
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 27, 2021
@guo-shaoge guo-shaoge closed this Nov 27, 2021
@guo-shaoge guo-shaoge reopened this Nov 27, 2021
@guo-shaoge
add more case
a21a6f0 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 27, 2021
@guo-shaoge guo-shaoge changed the title expression: enable pushdown substring to tikv expression: enable pushdown substring/char_length to tikv Nov 27, 2021
@guo-shaoge
fix case
0f1f66d 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge
fix case
81140b5 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge
trivial chg
499fd30 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
XuHuaiyu
XuHuaiyu approved these changes Nov 27, 2021
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 27, 2021
@zhouqiang-cl zhouqiang-cl merged commit 3eaff35 into pingcap:release-5.1-20211127 Nov 28, 2021
@guo-shaoge guo-shaoge mentioned this pull request Dec 2, 2021
Closed
@zhouqiang-cl zhouqiang-cl added this to the v5.1.4 milestone Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@bb7133 bb7133 bb7133 left review comments

Assignees
No one assigned
Labels
do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
v5.1.4
Development

Successfully merging this pull request may close these issues.
5 participants
@guo-shaoge @ti-chi-bot @bb7133 @XuHuaiyu @zhouqiang-cl